acmucsd / membership-portal

REST API for the UC San Diego ACM chapter's membership portal.

https://members.acmucsd.com

Mozilla Public License 2.0

17 stars 5 forks source link

Fix Bug Allowing Users to Reschedule to a Full Pickup Event #442

Closed nik-dange closed 5 months ago

nik-dange commented 5 months ago

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant motivation or context.

Users can reschedule to full pickup events and this is cooking the hardworking merch store managers

Changes

Added extra validation prior to rescheduling the order
Added it to a private method so I threw it in for placing order as well

Type of Change

[x] Patch (non-breaking change/bugfix)
[ ] Minor (non-breaking change which adds functionality)
[ ] Major (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (A change to a README/description)
[ ] Continuous Integration/DevOps Change (Related to deployment steps, continuous integration workflows, linting, etc.)
[ ] Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

[ ] locally.
[ ] on the testing API/testing database.
[ ] with appropriate Postman routes. Screenshots are included below.

Checklist

[ ] I have performed a self-review of my own code.
[ ] I have followed the style guidelines of this project.
[ ] I have appropriately edited the API version in the package.json file.
[ ] My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

github-actions[bot] commented 5 months ago

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.