acmucsd / membership-portal

REST API for the UC San Diego ACM chapter's membership portal.
https://members.acmucsd.com
Mozilla Public License 2.0
17 stars 5 forks source link

Removing Public Data Types from Service Layer (WIP) #444

Open yimmyj opened 5 months ago

yimmyj commented 5 months ago

Info

Closes #326.

Description

Refactoring every service-level file, replacing public types in the promises of methods with private types / models.

Changes

Type of Change

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

Checklist

Screenshots

github-actions[bot] commented 5 months ago

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.