search

acomagu / fish-async-prompt

Make your prompt asynchronous to improve the reactivity.
MIT License
390 stars 22 forks source link

`sh <defunct>` processes are spawned. #30

Closed acomagu closed 3 years ago

acomagu commented 4 years ago 
$ uname -a
Linux acm-manjaro 4.19.112-1-MANJARO #1 SMP Fri Mar 20 20:32:56 UTC 2020 x86_64 GNU/Linux
$ fish --version
fish, version 3.1.0
acomagu commented 4 years ago

function ... --on-process-exit PID seems not to be fired. --on-job-exit also doesn't work.

acomagu commented 4 years ago

Fixed at #31 for now. But still I need to inspect the problem more.

acomagu commented 4 years ago

Follow https://github.com/fish-shell/fish-shell/issues/6828

novadev94 commented 4 years ago

I noticed it while working on my own async git prompt too, --on-process-exit PID and --on-job-exit doesn't work for nested functions (declared locally) on Fish 3.1.0

acomagu commented 4 years ago

@NovaDev94 Thank you for the information. Hmm, that's a bit disappointing. I have no idea to do without function nesting.

davidcelis commented 3 years ago

is there any update on trying to get this to work with Fish 3.1.x?

acomagu commented 3 years ago

@davidcelis In my environment, it works on Fish 3.1.2. Do you have any trouble?

acomagu commented 3 years ago

I updated the issue title reflecting the current status. Now it works on Fish 3.1.x(if not, open new issue). I'm sorry if it made confusion.

acomagu commented 3 years ago

Fixed by https://github.com/fish-shell/fish-shell/pull/6861.