Incompatible with oh-my-posh

acomagu / fish-async-prompt

Make your prompt asynchronous to improve the reactivity.

MIT License

412 stars 25 forks source link

Incompatible with oh-my-posh #61

Open FWest98 opened 2 years ago

FWest98 commented 2 years ago

I have little understanding of what the code in this module does, but I do know that it is incompatible with the oh-my-posh prompt. To be specific, for some reason the variable $omp_status_cache seems to be empty, causing an invalid argument to be passed to the OMP executable here: https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/src/shell/scripts/omp.fish#L32

When I try to set async_prompt_inherit_variables all, I get even more issues (set: Tried to change the read-only variable “status_generation”). Would you maybe have an idea what is happening here?

acomagu commented 1 year ago

The error Tried to change the read-only variable “status_generation” is fixed at fcc8c25. Cloud you update the plugin and try async_prompt_inherit_variables all again?

If any problem still remains, please reopen. Thank you!

FWest98 commented 1 year ago

I still experience some issues with oh-my-posh. To be specific:

I get the following error message regularly: Error: invalid argument "--execution-time" for "-e, --error" flag: strconv.ParseInt: parsing "--execution-time": invalid syntax
The transient prompt feature does not work properly anymore

acomagu commented 1 year ago

oh-my-posh seems to be using global variables. fish-async-prompt doesn't currently support such prompt functions, as we have not come up with a way to make it work. I'm sorry.