acomagu / fish-async-prompt

Make your prompt asynchronous to improve the reactivity.
MIT License
389 stars 22 forks source link

set: Tried to change the read-only variable 'status_generation' #63

Closed jvolden closed 1 year ago

jvolden commented 1 year ago

Setting set -U async_prompt_inherit_variables all produces the error in the title.

~ ❱ fish --version
fish, version 3.5.0

Plugins:

~ ❱ fisher list
jorgebucaran/fisher
gazorby/fish-exa
laughedelic/fish_logo
jorgebucaran/nvm.fish
jethrokuan/z
jorgebucaran/autopair.fish
jorgebucaran/hydro
acomagu/fish-async-prompt

There may be a better way but I manually excluded that variable.

 144   │             for item in (set -ng)
 145   │                 if test "$item" != "status_generation"
 146   │                     echo $item
 147   │                 end
 148   │             end

Side note: I'm setting to all because hydro prompt does not show up with default values. I didn't take the time to see what variable fixes it, so I added them all.

acomagu commented 1 year ago

@jvolden Fixed. Thank you!

patricklewis commented 1 year ago

@acomagu Thank you for this plugin! It makes fish + Pure prompt even more enjoyable to use.

After upgrading to the latest commit (fcc8c25) I now see the status_generation error when I open a new shell

image

I don't believe I have ever set the async_prompt_inherit_variables variable

edit: I reverted to commit 275fed30f597 and no longer see the status_generation error.

acomagu commented 1 year ago

@patricklewis I'm sorry, I fixed the latest commit. Would you try it again after pull it? Thank you!

patricklewis commented 1 year ago

@acomagu I no longer get a "status_generation" error after that commit, thank you!