search

acomagu / fish-async-prompt

Make your prompt asynchronous to improve the reactivity.
MIT License
390 stars 22 forks source link

the async-prompt fish script will make fish prompt hang for v3.0 #7

Closed c02y closed 5 years ago

c02y commented 5 years ago

I've tried to comment/uncomment piece by piece in my config.fish, and it turns out that the async prompt fish script file made fish prompt hang. No other info, so if you need anything, please let me know.

acomagu commented 5 years ago

It is still working on my environment, fish 3.0.2.

acomagu commented 5 years ago

I'm really sorry for my late reply. Could you try again on newer version of fish, maybe? I don't know it's a related thing, but on my environment the master version of fish hung(even if without async-prompt). The release version(3.0.2) work.

c02y commented 5 years ago

Yeah, it works for v3.0.2 again.

Have you ever considered to write a pull request to fish-shell repo and let them merge this feature into fish-shell?

acomagu commented 5 years ago

Thank you. Hmm... Probably I won't create PR for fish core repository because this plugin works enough for me so I don't have motivation. Additionally I'm not familiar with such big C++ project. :thinking:

acomagu commented 5 years ago

But it's still nice feature, because Fish plugin often break. It's hard to maintain code to work on both of Linux and macOS.