Add SNI support for outgoing Mumble connections

acomminos / Jumble

An Android service implementation of the Mumble protocol.

GNU General Public License v3.0

90 stars 51 forks source link

Add SNI support for outgoing Mumble connections #13

Closed k3d3 closed 9 years ago

k3d3 commented 9 years ago

Some Mumble hosting services rely on SNI in order to connect to the correct server (where everyone shares the same port). The official Mumble client (as well as the iOS client) already supports SNI out of the box, however Plumble does not. This fixes Jumble and Plumble to support SNI.

acomminos commented 9 years ago

Looks good, thanks! In the future, it might be nice to make JumbleSSLSocketFactory backed by a SSLCertificateSocketFactory- it seems to provide a very clean and concise API for allowing client implementations using Jumble to ignore certificate validation if they wish.