acomminos / Jumble

An Android service implementation of the Mumble protocol.
GNU General Public License v3.0
90 stars 51 forks source link

Fixed clipping when mixing. #5

Closed BuddyButterfly closed 9 years ago

BuddyButterfly commented 9 years ago

Fixed the clipping and added a todo to remind on implementing a better mixing algorithm.

BuddyButterfly commented 9 years ago

I do not see the point to not merge this. Previous code also had the interval [-1.0,1.0] as pre-requisite but was wrong otherwise. Now we have the same pre-requisite and fixed the rest. Why not merge? It is such a small change.

acomminos commented 9 years ago

Sorry for the delay. Your solution is fine in the mean time until a better mixing algorithm can be implemented.

BuddyButterfly commented 9 years ago

Thanks maid. So we got at least rid of this one.