acomminos / wine-pba

Patches to add a persistent buffer allocator for faster dynamic geometry in Direct3D games.
GNU Lesser General Public License v2.1
137 stars 6 forks source link

Witcher 3 invisible characters and creatures #9

Open Thoma5 opened 6 years ago

Thoma5 commented 6 years ago

Tested it on my 970GTX, R7 1700@3.7GHz and pba-2.21 from lutris. Since I've not found a correct way to measure fps yet, I can't say anything precise about that, but it feels slightly improved. GPU Utilization went up about 10%, seems much more fluctating now (somewhere between 55 and 80% but usually around 70%). However, all characters and creatures are now invisible.

jrugia commented 6 years ago

Recorded a video of Witcher 3 with yesterday's PBA patches, characters still invisible: https://www.youtube.com/watch?v=6U7X_aXWxsI

Wine output log: log.txt

mirh commented 6 years ago

I'm kinda sure TW3 got heavily fixed in wine 3.2

Thoma5 commented 6 years ago

@mirh I'd appreciate this. However, it has nothing to do with this issue, since this issue is about a regression that is very likely caused by the pba patch.

stefson commented 6 years ago

Witcher 3 got even more fixed in wine-3.3, with the old wine-2.21 + staging + the patches from here, performance in fps is worse and characters/creatures are invisible.

jrugia commented 6 years ago

@stefson Are you on Mesa or Nvidia? I'm asking this because in my tests 2.21 + Staging + PBA completely trashes 3.3 + Buffer Patches in terms of performance.

A recent video I recorded using 2.21 + Staging + PBA shows much better performance than 3.3 + Patches (Link in my earlier post above).

By comparison 3.3 + Buffer Patches for me it runs at about 27 fps max and at a much lower detail. The frame drops are also more frequent. Mine is of course a performance comparison, the graphic errors are a separate issue.

stefson commented 6 years ago

I'm using an Radeon rx 550 with mesa-17.3.6, llvm-5, kernel 4.14 + amdgpu. With wine-2.21 + staging I have invisible characters just like you in the youtube video, it is not nvidia specific.

acomminos commented 6 years ago

Is there another game that can reproduce similar issues? I don't own TW3.

mirh commented 6 years ago

It shouldn't bother you too much. It was fixed in 3.3

jrugia commented 6 years ago

@mirh Unfortunately not yet, Recent Video 3.3 Staging + PBA: https://www.youtube.com/watch?v=t-FnjIg3JlA (not recorded by me).

stefson commented 6 years ago

So, I have to confirm the invisible characters with wine-3.3 + staging + PBA on radeon rx 550 with the amdgpu drivers. But performance is up from 1-2 fps, if at all, to maybe 10. So it points into the right direction :)

this is the output from the console, with errors and warnings console.zip

If you need some more Informations I can provide them, given that you tell me which commands to use for that in terms of debugging, I'm fairly inexperienced with winedebug.

Kerrung commented 6 years ago

I have this issue with PBA in TW3 too. All characters is still invisible with commit 1bc7015. But I haven't this issue without PBA.

acomminos commented 6 years ago

Overwatch had a similar issue, which I addressed in b33e274. If someone could check whether or not that commit fixes TW3, that would be great.

strycore commented 6 years ago

A build with the latest commit struggles with TW3. It takes ~30 seconds to get to the intro video (freezing the whole machine) then the video play without issue. Then it also takes another ~30 seconds to get to the game menu. Each timeI tried it, I had to unfocus the Wine window then re-focus it for the main menu to render at all (otherwise the game gets stucks on the last frame of the video). When the game regains focus, it renders frames at super high speed before stabilizing. I haven't got to the game itself. I seems like it gets stuck on the last frame of the video then my GPU just sits there at 100% utilization (RAM and CPU usage are ok)

strycore commented 6 years ago

FWIW, Hellblade had the same issue (invisible character) and it's still present with the latest build (except that now a piece of clothing is rendering)