acomputerguru / periscope

Automatically exported from code.google.com/p/periscope
0 stars 0 forks source link

Podnapisi support for HD tv series #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I'm using the latest build under windows and it works just fine.
(after modifying periscope.py for os.path.join that always complained about 
.config folder not existed )

I've been reading some logs files and noticed that no subtitles have been 
downloaded from podnapisi although this site has all of it.

I know that this site lists couple of matching releases.

see this for example:
http://www.podnapisi.net/ppodnapisi/podnapis/i/1322292

Does the latest version support such thing?
I mean searching for all matching subtitle.

I don't mind getting the xvid version and my past experience has shown me that 
there is a perfect sync even on the HD version.

Thanks

Original issue reported on code.google.com by asil...@gmail.com on 8 Oct 2011 at 11:39

GoogleCodeExporter commented 9 years ago
Attached is log file when Podnapisi found a match but could not download it.

Original comment by asil...@gmail.com on 8 Oct 2011 at 11:53

Attachments:

GoogleCodeExporter commented 9 years ago
hi,

it looks like the download failed for some reason. I'm currently halfway around 
the world on holiday so I'll take a look at it when I get back.

Original comment by patrick....@gmail.com on 8 Oct 2011 at 12:32

GoogleCodeExporter commented 9 years ago
When I disable addi7ed I noticed that this is the reason the subtitles were
not downloaded from Podnapisi

ERROR:periscope.periscope:global name 'searchurl' is not defined
INFO:periscope.periscope:Trying to download subtitle: None
WARNING:periscope.periscope:Subtitle None could not be downloaded, trying the 
next on the list
ERROR:periscope.periscope:global name 'searchurl' is not defined
ERROR:periscope.periscope:No subtitles could be chosen.

Line 79 in Podnapisi.py

Do you know what went wrong?

Original comment by asil...@gmail.com on 8 Oct 2011 at 12:39

GoogleCodeExporter commented 9 years ago
Attached is a debug log.
I spotted the problem but it will take me long time to debug since I dont know 
python so well.

I hope someone here could solve it.

The problem is that selectBestSubtitle returns None although there were 2 
candidates.

Thanks

Original comment by asil...@gmail.com on 8 Oct 2011 at 12:52

Attachments:

GoogleCodeExporter commented 9 years ago
After further debugging I noticed that
attempToDownloadSubtitle refers to attribute link.
the returned subtitle array from Podnapisi does not contain any link attribute.

I think it should use the page attribute.

Original comment by asil...@gmail.com on 8 Oct 2011 at 1:08

GoogleCodeExporter commented 9 years ago
podnapisi should set a link attribute that is the same than the page. Page 
means the download page, link means the download link

Original comment by patrick....@gmail.com on 8 Oct 2011 at 1:21

GoogleCodeExporter commented 9 years ago
Finally i found the bug :)

in createFile of Podnapisi.py one should change downloadContent from searchurl 
to subpage. :)

It was a touch debugging but finally I made it.

Original comment by asil...@gmail.com on 8 Oct 2011 at 1:22

GoogleCodeExporter commented 9 years ago
Fixed in r151. Thanks

Original comment by patrick....@gmail.com on 3 Nov 2011 at 9:10