periscope doesn't work on gvfs mounted file systems

acomputerguru / periscope

Automatically exported from code.google.com/p/periscope

0 stars 0 forks source link

periscope doesn't work on gvfs mounted file systems #78

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Right click on a movie that's on a file system mounted with gvfs.

What is the expected output? What do you see instead?
I expected to see the periscope menu entry, instead it is not displayed.

What version of the product are you using? On what operating system?
periscope 0.1.14 on ubuntu 10.10 64bit

Please provide any additional information below.
Even after I added smb as a valid uri scheme in is_valid() and the menu shows 
up, periscope doesn't work because it doesn't use gio/gvfs properly and instead 
uses a barbaric (sic!) way to get the path of the file (even though it uses 
lambda functions and map:)) instead of asking 
 gvfs about it.

Original issue reported on code.google.com by shoc...@gmail.com on 10 Feb 2011 at 7:43

GoogleCodeExporter commented 9 years ago

Sample patch. I'm not sure the uri scheme needs to be validated anymore in 
is_valid() since we now use gvfs. I just added "smb" to the list since that's 
what I was interested in. Enjoy. BTW, this is my first endeavor in gio/gvfs so 
all bets are off!

Original comment by shoc...@gmail.com on 10 Feb 2011 at 8:02

Attachments:

periscope-gvfs.patch

GoogleCodeExporter commented 9 years ago

I knew two years ago when I wrote that code that some day someone would need 
remote access to videos :)

You're probably right that the file:// check is probably not very relevant with 
gvfs.

By the way, do you know which Ubuntu package includes the gio python module ? I 
would need to know it for package purposes. Is it pygobject ?

Original comment by patrick....@gmail.com on 15 Feb 2011 at 10:05

GoogleCodeExporter commented 9 years ago

I think it's python-gobject. Doing a dpkg -L python-gobject reveals that it has 
a gio module so I think that's it, but my detective skills are a bit worn out 
after midnight :)

Original comment by shoc...@gmail.com on 15 Feb 2011 at 10:14

GoogleCodeExporter commented 9 years ago

applied in r140

Original comment by patrick....@gmail.com on 17 May 2011 at 9:16

Changed state: Fixed