search

aconrad / pycobertura

A code coverage diff tool for Cobertura reports
MIT License
114 stars 39 forks source link

Fix/handle multiple classes in same files correctly #132

Closed gro1m closed 2 years ago

gro1m commented 2 years ago

Hi @aconrad I try to continue on PR #113 here, as @smortvedt did not yet reply and may have lost interest in the project.

As a first, I just merged in his changes into my master and put it into a new branch.

gro1m commented 2 years ago

Hi @aconrad Also this is ready for review, unfortunately Python 3.8 and Python 3.9 are still red, albeit the diff is small, that might give an easier indication what is different in Python 3.8 and 3.9...

aconrad commented 2 years ago

Hi @aconrad Also this is ready for review, unfortunately Python 3.8 and Python 3.9 are still red, albeit the diff is small, that might give an easier indication what is different in Python 3.8 and 3.9...

Do you have both py37 and py38/py39 installed? The generated coverage files for each interpreters might be worth looking at. I'm not in front of my laptop but if you were to upload the files in a new GitHub issue that would be great so we can take a look at what is different. Do you think you can do that?