search

aconrad / pycobertura

A code coverage diff tool for Cobertura reports
MIT License
116 stars 39 forks source link

Export Json and Yaml as List of Objects #153

Closed gro1m closed 2 years ago

gro1m commented 2 years ago

Addresses https://github.com/aconrad/pycobertura/issues/146.

@aconrad Please review! FYI: @notpushkin

aconrad commented 2 years ago

Ah, we're getting conflicts now, naturally.

gro1m commented 2 years ago

Ah, we're getting conflicts now, naturally.

resolved :)

aconrad commented 2 years ago

@gro1m would you want me to take over this PR or can you fix the merge conflict so we can get this one merged?

gro1m commented 2 years ago

Hi @aconrad I tried to merge the PR and resolve the conflict, but currently I can only do this via the editor, which is a bit error-prone. So if you could resolve it, great. Otherwise it will take me certainly another week until I can take a look at it.

aconrad commented 2 years ago

Sounds good. I'll try to take a look at it today.

aconrad commented 2 years ago

Oh, you did merge master and resolve the conflict actually. I can look at the failing tests then.

aconrad commented 2 years ago

@gro1m here's a PR to fix tests: https://github.com/gro1m/pycobertura/pull/1

It's a PR against your branch on your fork. Not sure if that's the best way to go about it but heh, let's give it a try. 😄

gro1m commented 2 years ago

@gro1m here's a PR to fix tests: gro1m#1

It's a PR against your branch on your fork. Not sure if that's the best way to go about it but heh, let's give it a try. 😄

Hi @aconrad That worked well, thanks! :)

notpushkin commented 2 years ago

🎉 Thanks folks!