Closed ernestask closed 1 year ago
Thanks for tackling this issue @ernestask, much appreciated. 🙏
tests/test_filesystem.py
?tests/test_cobertura_diff.py
? I see you already posted a ZIP file that includes a reproducible scenario for this issue, thank you! Could we use that in the tests/
directory to demonstrate the issue for a diff test?Hey, yeah, I’ll look into that tomorrow.
Additionally, can we add an entry under ## Unreleased
in CHANGES.md
that explains what was fixed?
Added some tests. Didn’t need to add another source archive, the dummy one can be used as well.
:pray:
Do you think .1 could be tagged with this? I’d start using it right away in that case.
Awesome, thanks a lot!
Currently, when mixing DirectoryFileSystem and ZipFileSystem, diffing reports wrong results for identical coverage reports due to differing types in file systems (byte-string lines compared with text lines).
This commit wraps the files opened from a zip archive inside TextIOWrapper to avoid the issue.
Closes https://github.com/aconrad/pycobertura/issues/107