Add resources field to computeclass #2380

[dciangot]

The edited version of the computeclass will allow to specify any kind of resources allowed by K8s corev1.ResourceRequirements. In principle that should be enough to enable admins to create computeclass with GPU and accelarators in general.

NOTES/QUESTIONS

• The quota management of these resources is postponed for later times as per @cjellick suggestion, since it will take some more thoughts.
• To avoid conflicts with the "first class" fields for memory and cpu scaling the client should rise an error if the admin tries to push a complute class where memory/cpu limits/requests are passed into the "resources" field. I have an integration test ready for this, but commented out since I'm failing to find the proper spot in the codebase where to implement such a check.

Checklist

• [ ] The title of this PR would make a good line in Acorn's Release Note's Changelog
• [ ] The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
• [ ] All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
• [ ] Commits follow contributing guidance
• [ ] Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
• [ ] Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
• [ ] PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

[cjellick]

Context is this slack thread: https://acorn-users.slack.com/archives/C03R9ME0SKC/p1702567598185389

@ibuildthecloud effectively blessed the approach conceptually

[dciangot]

Thank you for your contribution!

Additional to my comments, I believe you also need to check in the changes generated from running make generate. The CI would have caught that had it run.

Thank you @thedadams , indeed I missed that make step, sorry about that.

Although there are two open comments, I pushed the changes that I found more in line with my understanding. Also, I added the update to the admin documentation, that I completely missed before.

[dciangot]

the recent commit broke the new tests for computeclass, I have rebased on the current main, hope it is ok for you

[cjellick]

Looks like a new commit came in. WIll need rereviewed @thedadams @tylerslaton

Tyler, once this is good, can you own getting it merged and shepherding it along internally (whatever that may mean...actually dont think theres much to do there other than merge)

[dciangot]

Yeah, it was on the latest @thedadams request. Now integration is failing, not related to the changes I made though. I can take a look later, meanwhile any hint is welcome.

[cjellick]

we'll rekick the tests after it officially fails to see if it was a flake

[tylerslaton]

Merging now, thanks for the contribution @dciangot!