acorn-io / runtime

A simple application deployment framework built on Kubernetes
https://docs.acorn.io/
Apache License 2.0
1.14k stars 101 forks source link

promptOrder is not respected for secrets with credential type #2386

Closed sangee2004 closed 6 months ago

sangee2004 commented 7 months ago

acorn version - v0.10.0-rc1-7-g8b9acb47+8b9acb47

Steps to reproduce the problem:

  1. Deploy app that has secrets with promptOrder
    secrets: config: {
    type: "credential.acorn.io/mytest"
    params: {
        promptOrder: ["proto", "address", "port", "adminUsername", "adminPassword", "username", "password"]
    }
    data: {
        address:       ""
        port:          ""
        username:      ""
        password:      ""
        adminUsername: ""
        adminPassword: ""
        proto:         ""
        dbName:        ""
    }
    }
  2. Following is the order in which I am prompted to enter data which is not respecting the promptOrder specified for the secrets:
mytestapp
STATUS: ENDPOINTS[] HEALTHY[] UPTODATE[] 
? address **
? adminPassword ***
? adminUsername ***
? dbName ***
? password ***
? port ***
? proto **
? username ***

Expected Behavior: Order in which user is prompted should be the same as the promptOrder specified for the secrets.

cloudnautique commented 6 months ago

Prompt order is now available on Main.

sangee2004 commented 6 months ago

Tested with - acorn version - v0.10.1-rc1-8-gce008aeb+ce008aeb

User is promoted as per the prompt order for credential creation.