acorn-io / runtime

A simple application deployment framework built on Kubernetes
https://docs.acorn.io/
Apache License 2.0
1.13k stars 100 forks source link

fix: resolved offerings: prioritize -m over Acornfile (#2415) #2416

Closed g-linville closed 10 months ago

g-linville commented 10 months ago

for #2415

When a user does -m <memory> to override the memory for all containers in the app, this takes precedence over any specific values set in the Acornfile for a container. I previously had these in the wrong order of precedence, but this PR fixes that.

Checklist

g-linville commented 10 months ago

I should've caught this in the original review, sorry about that. Thanks for the fix.

All good, man! I should have realized when I implemented it, lol.