acorn-io / runtime

A simple application deployment framework built on Kubernetes
https://docs.acorn.io/
Apache License 2.0
1.14k stars 101 forks source link

fix: credential secrets: avoid race condition when prompting user (#2410) #2422

Closed g-linville closed 6 months ago

g-linville commented 6 months ago

for #2410

There is a race condition that occurs only when deploying an acorn to the SaaS that defines a credential secret. The user will be prompted to enter credentials multiple times because the app keeps changing upstream. If we wait for a little bit (until all containers are marked as Defined), the race condition doesn't occur, and the user is only prompted once.

I also tested this with Acornfiles that only define this secret and a nested acorn, as well as an Acornfile that defines just the secret and nothing else, and it still works just fine.

Checklist