acorn-io / runtime

A simple application deployment framework built on Kubernetes
https://docs.acorn.io/
Apache License 2.0
1.14k stars 102 forks source link

fix: calculate resolvedOfferings for sidecars #2451

Closed g-linville closed 5 months ago

g-linville commented 5 months ago

@tylerslaton reported this issue to me this morning. My previous implementation of this was taking the resolved offerings for a container and setting them for all sidecars on the container as well. Not sure what I was thinking, because that was very incorrect. With this PR, sidecars get their offerings resolved the same way that normal containers do.

Checklist