search

acorn-io / runtime

A simple application deployment framework built on Kubernetes
https://docs.acorn.io/
Apache License 2.0
1.13k stars 100 forks source link

fix: allow hostname to start with number when binding #2464

Closed thedadams closed 10 months ago

sangee2004 commented 10 months ago

Tested with acorn version - v0.10.1-rc1-25-g92d24ac7

Able to deploy apps successfully with publish urls having hostname start with number

acorn run  -p 111.<example-domain>-n mytestpublish ghcr.io/acorn-io/library/hello-world
acorn apps
NAME               IMAGE                                  COMMIT         CREATED    ENDPOINTS                                                                                     MESSAGE
mytestpublish      ghcr.io/acorn-io/library/hello-world   eab5f8c77bd6   97s ago    https://111.<example-domain>/, https://mytestpublish-xxx.<domain>/          OK

Able to access publish urls successfully.