search

acornejo / jquery-cropbox

jQuery Cropbox plugin
http://acornejo.github.io/jquery-cropbox/
MIT License
345 stars 82 forks source link

Use buttons instead of links for zoom buttons #44

Closed richard-flosi closed 10 years ago

richard-flosi commented 10 years ago

Using an a tag without a href or even with a href="#" can produce undesirable results in IE9, i.e. linking or triggering a route. This issue is easily avoidable by using a button instead. This issue is probably most relevant to single-page web applications.

I've pushed a demo of these changes to my gh-pages branch which you can see here: http://richard-flosi.github.io/jquery-cropbox/

This Pull Request simply changes the a tags to button and updates the css accordingly to make sure the +/- are centered in the button.

acornejo commented 10 years ago

I don't use IE, but I'll take your word for it that the a tag without href causes havok. Merged pull request. (thanks for the demo, saved me some time and allowed me to merged faster).

richard-flosi commented 10 years ago

Right on. I probably should have version bumped too. You want a Pull Request for that as well?

acornejo commented 10 years ago

Nah, its cool, I'll do it later (I'll take this chance to fix a couple of other quirks).