search

acornejo / jquery-cropbox

jQuery Cropbox plugin
http://acornejo.github.io/jquery-cropbox/
MIT License
345 stars 82 forks source link

Rotate Image #61

Closed emaortiz closed 10 years ago

emaortiz commented 10 years ago

Hi, Could you provide me an example of image rotation with custom controls, Please?

acornejo commented 10 years ago

rotation is not supported by this plugin.

josuerios commented 10 years ago

Hi acornejo: Recently i added rotation support for the plugin, perhaps isn't a clean implementation but it does the trick if you could add me as contributor I could help you supporting the plugin, Best regards,

2014-11-14 12:19 GMT-05:00, Alex Cornejo notifications@github.com:

Closed #61.

Reply to this email directly or view it on GitHub: https://github.com/acornejo/jquery-cropbox/issues/61#event-193474041

acornejo commented 10 years ago

Hi jdavoff,

If you are interested in becoming a contributor, I will gladly add you. I tried to look at your repositories in github to see some of your code, but I could find no repositories.

I am not actively using javascript anymore, so I am definitely interested in new maintainers. That being said, I would like to keep the code base clean and simple, since there are already plenty of really complicated plugins out there, some of them with rotation.

To name a couple:

https://github.com/cropzoom/cropzoom http://matiasgagliano.github.io/guillotine/

Cheers,

Alex

josuerios commented 9 years ago

Hi acornejo: First of all thanks for replying, I'm recently new in github so you wouldn't find any repositories of my own. I studied the plugins you mentioned and find yours more suitable for my work, thanks to the mousewheel and hammer integration. I managed a way to add rotation via HTML5 canvas, and as I said before it does the trick very well, I have tested it across some browsers and it works fine up to now.

acornejo commented 9 years ago

@jdavoff no problem. Let me suggest that you create a pull-request that implements that feature. That way I can take a look at the code and test it on my computer. After you do that I'll create a new github group that includes you and me, so that we both have commit rights to the repository, and you can keep making changes and maintaining jquery-cropbox without my involvement.

Cheers,

Alex

thorne51 commented 9 years ago

Was this ever integrated? I just noticed on my Sony Xperia E3 phone that when initializing the plugin on an uploaded photo that you just took, the rotation is wrong and would like to provide users with a rotation control to rotate the photo by 90 degrees clock/anti-clockwise.