acornjs / acorn-jsx

Alternative, faster React.js JSX parser
MIT License
648 stars 74 forks source link

Fix in child XJS MemberExpression #1

Closed NekR closed 10 years ago

NekR commented 10 years ago

Without that fix, this code fails:

var jsx = require("acorn-jsx");

console.log(jsx.parse('<A aa={aa.bb.cc} bb={bb.cc.dd}><div>{aa.b}</div></A>'));
RReverser commented 10 years ago

Thanks! Please include test for this code in PR (for regression testing in future).

RReverser commented 10 years ago

And please fix the build - it's failing now in Travis.

NekR commented 10 years ago

And please fix the build - it's failing now in Travis.

Yep, sorry. Fixed.

Thanks! Please include test for this code in PR (for regression testing in future).

I think I do not understand what means 'PR', but I added tests for npm test. Did you mean that?

RReverser commented 10 years ago

I think I do not understand what means 'PR', but I added tests for npm test. Did you mean that?

That is common abbreviation for Pull Request. Thanks for fixing, I'll check it out.

RReverser commented 10 years ago

Thanks! Spent some time figuring out if we can get rid of additional variable, but seems - no :(