Closed NekR closed 10 years ago
Thanks! Please include test for this code in PR (for regression testing in future).
And please fix the build - it's failing now in Travis.
And please fix the build - it's failing now in Travis.
Yep, sorry. Fixed.
Thanks! Please include test for this code in PR (for regression testing in future).
I think I do not understand what means 'PR', but I added tests for npm test. Did you mean that?
I think I do not understand what means 'PR', but I added tests for npm test. Did you mean that?
That is common abbreviation for Pull Request. Thanks for fixing, I'll check it out.
Thanks! Spent some time figuring out if we can get rid of additional variable, but seems - no :(
Without that fix, this code fails: