search

acornjs / acorn-jsx

Alternative, faster React.js JSX parser
MIT License
648 stars 72 forks source link

Add .npmrc to prevent lockfile from being created #107

Closed kaicataldo closed 2 years ago

kaicataldo commented 4 years ago

I noticed that this repo doesn't include a lockfile but doesn't have .npmrc preventing the lockfile from being created. Figured I could make a quick PR :)

RReverser commented 4 years ago

What's the usecase for this / where Git-ignoring lockfiles is not enough?

kaicataldo commented 4 years ago

Allowing the creation of lockfiles could lead to a local npm install respecting package-lock.json, making the local dev environment different from CI. It would be caught in CI, so not a huge deal, but might help save some time/confusion. If this isn't something you think is useful, please feel free to close the PR :)

Qix- commented 3 years ago

where Git-ignoring lockfiles is not enough?

The only place is CI that caches artifacts. Using npmrc is considered "proper" for this reason.