search

acornjs / acorn-jsx

Alternative, faster React.js JSX parser
MIT License
646 stars 72 forks source link

`openingFragment` and `closingFragment` should be JSXOpeningFragment and JSXClosingFragment for JSX fragments #84

Closed ArtemGovorov closed 6 years ago

ArtemGovorov commented 6 years ago

Addressing https://github.com/RReverser/acorn-jsx/pull/83#issuecomment-349726310

RReverser commented 6 years ago

Looks like fragments also shouldn't have name field at all.

ArtemGovorov commented 6 years ago

@RReverser Removed the name field.

adrianheine commented 6 years ago

Is this in a state were it could be merged? Rich-Harris/buble#62 is waiting for this to be released :)

RReverser commented 6 years ago

It is! I'm on holidays with family but going to merge this next week (feel free to ping me again in case I forget).

adrianheine commented 6 years ago

Oh, sorry, please take your time :)

RReverser commented 6 years ago

Released as 4.1.1 (since technically it's a bug fix, although I really hope no one started depending on the incorrect node type).

developit commented 6 years ago

this might have broke rollup/buble (not sure which yet)

adrianheine commented 6 years ago

rollup doesn't even use this, and unless you're pulling bublé master you're not seeing this.