search

acornjs / acorn

A small, fast, JavaScript-based JavaScript parser
10.6k stars 885 forks source link

Upgrade acorn/test/bench/fixtures/react(-dom).js to v16 or later #734

Closed tsteenbe closed 1 year ago

tsteenbe commented 6 years ago

Could acorn/test/bench/fixtures/react.js and acorn/test/bench/fixtures/react-dom.js be upgraded to version v16.0 or later?

I am asking since both files are current React v15.5.4 and ReactDOM v15.5.4 which is licensed under Facebook's BSD3+Patents which causes acorn to be flagged by OSS compliance tooling as "Review Required".

@RReverser If it's as simple as submitting a PR with upgraded version then I happy create a PR for this.

marijnh commented 6 years ago

Yeah, these are just treated as inputs, so a PR that upgrades them should be uncontroversial. (Given the license, issue, I'd say it would be very welcome, in fact.)

RReverser commented 6 years ago

Yup, happy to accept a PR.

marijnh commented 1 year ago

No PR happened, going to close this since there's no pressing reason to care about the version of the benchmark inputs.