search

acortell3 / archaeoriddle

CDAL collaborative ABM
2 stars 0 forks source link

Add libraries and packages dependencies in readme + remove useless packages #15

Closed ismaRP closed 9 months ago

ismaRP commented 11 months ago

Since this is not a package yet, the dependencies are not automatically taken care of. So we could add them to the github readme in case people want to implement and run the functions themselves.

At least for me running Ubuntu there are a couple of libraries that I had to install separately: libgdal-dev, libudunits2-dev and libgeos-dev It was not a problem, they got indicated when I tried to install terra (although libgdal-dev was not directly mentioned), but it would be nice to have them all in one place.

simoncarrignon commented 11 months ago

Quick note: we dicided to put int in the readme which I did in 3b92c4973168b2a4bf0dbb50ccbd95479105f6d3 . Note that I don't close the issue as I think we should/could go throught them all and check if they are really needed or could be replaced by simple function:

acortell3 commented 10 months ago

I've checked. Seems like we're not using vctrs in any script any more, so it can be removed. I'd keep viridis and igraph, otherwise we'll have to redo palettes and DAGs and all by hand. Rayshader is just used in an example in the third chapter. Up to you Simon, really, whether you want to keep it or not

simoncarrignon commented 9 months ago

@ismaRP quick question on these: https://github.com/acortell3/archaeoriddle/blob/10a31b1eae45aba22f6dbf4a9b98da358e4243c6/doc/bookdown/index.Rmd#L31-L33 why is tidyverse here? do we need that anywhere? Should the package.bib file also create after that all packages are loaded?

ismaRP commented 9 months ago

No not really, I don't how that appeared there.

And yes, it should probably create it only after. And I also wonder if we should include the archaeoriddle package itself

simoncarrignon commented 9 months ago

To me this sounds done, also we could add in the README the Debian/Ubuntu packages that are needed to install all these packages...

acortell3 commented 9 months ago

Yep, I think that would be a good idea... It's not really necessary, since unlike me, Ubuntu/Debian users should already be aware that they have to install some dependencies independently, but it certainly wouldn't hurt... I did write down all the packages (lib*) I had to install in the command line, so it's easy to do... I should be able to modify the readme today