search

acoustep / ember-cli-foundation-6-sass

MIT License
64 stars 33 forks source link

Deprecation warning of Ember.$() in ember 3.9 #103

Closed alejomo closed 3 years ago

alejomo commented 5 years ago

Fresh install Ember 3.9 i'm getting several warnings in the browser console:

DEPRECATION: Using Ember.$() has been deprecated, use import jQuery from 'jquery'; instead [deprecation id: ember-views.curly-components.jquery-element] See https://emberjs.com/deprecations/v3.x#toc_jquery-apis for more details.

therealbenhogan commented 5 years ago

Hi, have the same issue (3.10)

cesarizu commented 5 years ago

I have a branch https://github.com/GovSciences/ember-cli-foundation-6-sass/tree/jquery-fix that fixes most of this.

therealbenhogan commented 5 years ago

Many thanks César - I'll take a look

zion commented 5 years ago

Same issue for me too on 3.11.

zion commented 4 years ago

@cesarizu Can you open a PR for this change? Maybe @acoustep can merge it in when he has time.

acoustep commented 4 years ago

I'm happy to merge if you submit a request 🙂

cesarizu commented 4 years ago

I've opened the PR at acoustep/ember-cli-foundation-6-sass#104 with the code that we've been using for quite some time. Please let me know if there's anything that I should change.

acoustep commented 4 years ago

Thanks @cesarizu! I have accepted and bumped the version number.

zion commented 4 years ago

Awesome work. Thanks!

zion commented 4 years ago

@acoustep should npm automatically acknowledge v26? It still says 25 is the latest

acoustep commented 4 years ago

@zion sorry I needed to publish the update. This is done now 👍

zion commented 4 years ago

Thanks mate!