search

acoustep / ember-cli-foundation-6-sass

MIT License
64 stars 33 forks source link

Is there a plan to upgrade to foundation 6.2.1? #20

Closed nadavshatz closed 7 years ago

nadavshatz commented 8 years ago

Wondering if there is a plan to upgrade this to foundation 6.2.1 and if a PR would help?

acoustep commented 8 years ago

PRs are more than welcome, I'll try and get on to this sorted tonight otherwise :)

nadavshatz commented 8 years ago

@acoustep great thanks. Let me know if it ends up falling between the cracks and I'll give it a go.

acoustep commented 8 years ago

I've updated the Foundation version in Bower. All of the components work except for offset canvas, which I haven't had a chance to look in to properly yet.

kaermorchen commented 8 years ago

@acoustep I also want to say thank you. I use foundation and your addon really helped me.

acoustep commented 8 years ago

@kaermorchen no problem, I'm glad it's helped!

kaermorchen commented 8 years ago

@acoustep a property "revealClass" not work in zf-off-canvas component.I try to do {{#zf-off-canvas revealClass="reveal-for-large" as |section| }} but class 'reveal-for-large' not added to element '.off-canvas.position-left'

andycochran commented 7 years ago

How about 6.4.1? (Should this issue be closed?)

GCheung55 commented 7 years ago

Adding revealClass="reveal-for-large" for with foundation-sites@6.4.1 isn't working either. I just tried it on the dummy app.

What did work was going into addon/templates/components/zf-off-canvas.hbs and adding reveal-for-large class to the elements with off-canvas class.

Something like:

<div class="off-canvas position-left reveal-for-large" id="zf-off-canvas-left" data-off-canvas>
    {{yield offCanvasLeftContent}}
</div>
GCheung55 commented 7 years ago

I've filed a ticket to address the revealClass issue, #83.

Closing issue because foundation-sites@6.4.1 is supported, though support is kind of buggy. Please re-open the ticket if you feel the ticket closure is in error.