search

acoustep / ember-cli-foundation-6-sass

MIT License
64 stars 33 forks source link

foundation-sites 6.3 breaks build #44

Closed simonexmachina closed 7 years ago

simonexmachina commented 7 years ago

foundation-sites 6.3 now imports SCSS from the _vendor/ directory using @import "../_vendor/normalize-scss/sass/normalize";. This isn't supported by the current broccoli config, because ../_vendor isn't in the tree.

One solution would be to change index.js:

var foundationPath = path.join(app.bowerDirectory, 'foundation-sites');

But then everyone would have to update their SCSS to @import 'scss/foundation'. Not sure what the best solution is here - might need to use some Broccoli magic to make this work. In the meantime we might want to use a version specifier that avoids users getting v6.3.

simonexmachina commented 7 years ago

My workaround for now is to change bower.json to use "foundation-sites": "~6.2.3" to avoid v6.3.

bravo-kernel commented 7 years ago

Looks like a dupe of https://github.com/acoustep/ember-cli-foundation-6-sass/issues/40

GCheung55 commented 7 years ago

Perhaps update index.js to determine the correct path depending on what version of foundation-sites is installed?