search

acoustep / ember-cli-foundation-6-sass

MIT License
64 stars 33 forks source link

Support foundation sites 6.3.0 #45

Closed GCheung55 closed 7 years ago

GCheung55 commented 7 years ago

Fixes #44.

I'm not sure this is considered a breaking change because loading of foundation in scss/sass is changed.

From:

@import "foundation";

To:

@import "foundation-sites/foundation";

I have yet to update the blueprint and would like some direction there.

GCheung55 commented 7 years ago

Also something to consider, adding an assert so that users install the correct version when the addon is included?

GCheung55 commented 7 years ago

@acoustep What are your thoughts?

acoustep commented 7 years ago

Hi @GCheung55

Thanks for submitting this fix :). This is a tricky one, but unfortunately due to the changes with Foundation it has to be done!

I will merge the PR. If you want to add an assert I think it would be beneficial for users