Makes the tests pass again

jurecuhalev commented 7 years ago
Fixes zf-dropdown-test Marks zf-reveal as a failing list
It would be great to all have tests run on pull-requests.
GCheung55 commented 7 years ago
Do you have a stack trace or other information as to why the zf-reveal test is failing?
jurecuhalev commented 7 years ago
Sorry, forgot to include this:
not ok 31 PhantomJS 2.1 - Integration | Component | zf reveal: it destroys the reveal-overlay
    ---
        actual: >
            false
        expected: >
            true
        stack: >
            exception@http://localhost:7357/assets/test-support.js:7338:46
            adapterDispatch@http://localhost:7357/assets/vendor.js:59057:22
            dispatchError@http://localhost:7357/assets/vendor.js:37173:23
            invokeWithOnError@http://localhost:7357/assets/vendor.js:19567:14
            flush@http://localhost:7357/assets/vendor.js:19623:15
            flush@http://localhost:7357/assets/vendor.js:19747:20
            end@http://localhost:7357/assets/vendor.js:19817:28
            run@http://localhost:7357/assets/vendor.js:19931:19
            run@http://localhost:7357/assets/vendor.js:41829:32
            set@http://localhost:7357/assets/test-support.js:8457:35
            http://localhost:7357/assets/tests.js:416:13
            runTest@http://localhost:7357/assets/test-support.js:3295:34
            run@http://localhost:7357/assets/test-support.js:3281:13
            http://localhost:7357/assets/test-support.js:3473:15
            advance@http://localhost:7357/assets/test-support.js:2958:26
            begin@http://localhost:7357/assets/test-support.js:4654:27
            http://localhost:7357/assets/test-support.js:3843:11
        message: >
            Error: NotFoundError: DOM Exception 8
        Log: |
            { type: 'error',
              text: '\'removeChild@[native code]\\nclear@http://localhost:7357/assets/vendor.js:18524:3101\\nreset@http://localhost:7357/assets/vendor.js:18526:7739\\nhandleException@http://localhost:7357/assets/vendor.js:18722:10782\\nhandleException@http://localhost:7357/assets/vendor.js:18723:2105\\n_throw@http://localhost:7357/assets/vendor.js:18722:5893\\nevaluate@http://localhost:7357/assets/vendor.js:18470:7196\\nexecute@http://localhost:7357/assets/vendor.js:18722:5626\\nrerender@http://localhost:7357/assets/vendor.js:18710:21964\\nrender@http://localhost:7357/assets/vendor.js:31391:26\\nrunInTransaction@http://localhost:7357/assets/vendor.js:42590:28\\n_renderRoots@http://localhost:7357/assets/vendor.js:31652:76\\n_renderRootsTransaction@http://localhost:7357/assets/vendor.js:31690:26\\n_revalidate@http://localhost:7357/assets/vendor.js:31729:35\\ninvokeWithOnError@http://localhost:7357/assets/vendor.js:19564:20\\nflush@http://localhost:7357/assets/vendor.js:19623:15\\nflush@http://localhost:7357/assets/vendor.js:19747:20\\nend@http://localhost:7357/assets/vendor.js:19817:28\\nrun@http://localhost:7357/assets/vendor.js:19931:19\\nrun@http://localhost:7357/assets/vendor.js:41829:32\\nset@http://localhost:7357/assets/test-support.js:8457:35\\nhttp://localhost:7357/assets/tests.js:416:13\\nrunTest@http://localhost:7357/assets/test-support.js:3295:34\\nrun@http://localhost:7357/assets/test-support.js:3281:13\\nhttp://localhost:7357/assets/test-support.js:3473:15\\nadvance@http://localhost:7357/assets/test-support.js:2958:26\\nbegin@http://localhost:7357/assets/test-support.js:4654:27\\nhttp://localhost:7357/assets/test-support.js:3843:11\'\n' }
            { type: 'error',
              text: '\'_destroy@http://localhost:7357/assets/vendor.js:79036:23\\ndestroy@http://localhost:7357/assets/vendor.js:69735:20\\nhttp://localhost:7357/assets/vendor.js:83773:25\\ninvokeWithOnError@http://localhost:7357/assets/vendor.js:19564:20\\nflush@http://localhost:7357/assets/vendor.js:19623:15\\nflush@http://localhost:7357/assets/vendor.js:19747:20\\nend@http://localhost:7357/assets/vendor.js:19817:28\\nrun@http://localhost:7357/assets/vendor.js:19931:19\\nrun@http://localhost:7357/assets/vendor.js:41829:32\\nteardownContainer@http://localhost:7357/assets/test-support.js:9181:27\\nhttp://localhost:7357/assets/test-support.js:7679:32\\ninitializePromise@http://localhost:7357/assets/vendor.js:67599:15\\nPromise@http://localhost:7357/assets/vendor.js:68087:50\\nnextStep@http://localhost:7357/assets/test-support.js:7678:51\\ntryCatch@http://localhost:7357/assets/vendor.js:67549:22\\ninvokeCallback@http://localhost:7357/assets/vendor.js:67564:23\\nhttp://localhost:7357/assets/vendor.js:67639:32\\nhttp://localhost:7357/assets/vendor.js:58224:24\\ninvokeWithOnError@http://localhost:7357/assets/vendor.js:19564:20\\nflush@http://localhost:7357/assets/vendor.js:19623:15\\nflush@http://localhost:7357/assets/vendor.js:19747:20\\nend@http://localhost:7357/assets/vendor.js:19817:28\\nhttp://localhost:7357/assets/vendor.js:20383:19\'\n' }
    ...
jurecuhalev commented 7 years ago
Closing this in favor of #78
acoustep / ember-cli-foundation-6-sass

Makes the tests pass again #76
