search

acoustep / ember-cli-foundation-6-sass

MIT License
64 stars 33 forks source link

zf-off-canvas does not support revealClass option. #83

Open GCheung55 opened 7 years ago

GCheung55 commented 7 years ago

From a comment in #20:

kaermorchen: @acoustep a property "revealClass" not work in zf-off-canvas component.I try to do {{#zf-off-canvas revealClass="reveal-for-large" as |section| }} but class 'reveal-for-large' not added to element '.off-canvas.position-left'

GCheung55: Adding revealClass="reveal-for-large" for with foundation-sites@6.4.1 isn't working either. I just tried it on the dummy app.

What did work was going into addon/templates/components/zf-off-canvas.hbs and adding reveal-for-large class to the elements with off-canvas class.

Something like:

<div class="off-canvas position-left reveal-for-large" id="zf-off-canvas-left" data-off-canvas>
   {{yield offCanvasLeftContent}}
</div>

I think we should rethink how zf-off-canvas works - maybe make it more composable with component closures?

bravo-kernel commented 7 years ago

This would be most welcome