search

acoustid / acoustid-server

AcoustID's web site and API
MIT License
64 stars 20 forks source link

Submission with duration > 32767 #43

Open phw opened 5 years ago

phw commented 5 years ago

Submitting a fingerprint for a duration > 32767 currently fails due to https://github.com/acoustid/acoustid-server/blob/8a8112c1ce26bbdcd73473eccc86d7040a42f834/acoustid/api/v2/__init__.py#L631

Is this a strict limitation because that value gets used elsewhere as a signed integer, or could it be lifted? Maybe at least allow the size of an unsigned int with 32bits? The only real limitation I could immediately see is the schema using smallint, but I guess that could be easily set to integer.

See the related issue reported against Picard on https://tickets.metabrainz.org/browse/PICARD-1486

phw commented 4 years ago

@lalinsky What do you think, could this be easily fixed server side (maybe just by changing the code above and probably adapting the database schema) or is there some bigger issue with this? How problematic is the schema change in regards to migration time and data size?