search

acoustid / chromaprint

C library for generating audio fingerprints used by AcoustID
Other
969 stars 132 forks source link

Port to ffmpeg 5.0 #114

Closed Yesterday17 closed 2 years ago

Yesterday17 commented 2 years ago

Thanks #108

I'm not experienced in C++, and not familiar with ffmpeg. Please review the code carefully :pray:

This pull request also fixes an existing issue as a by-product of refactoring the Read method. Now fpcalc can calculate fingerprint of m4a files correctly. The problem was found by @kaaass while using fingerprint with MusicBrainz. fpcalc would run into an infinite loop when computing fingerprint of m4a files on my laptop.

I tested this PR on a WAV file and a FLAC file. The fingerprint did not change after the patch(at least for these two files).

Fixes #33 Fixes #110

sergiomb2 commented 2 years ago

duplicated of https://github.com/acoustid/chromaprint/pull/108 ?

Yesterday17 commented 2 years ago

duplicated of #108 ?

Fix in #108 does not work correctly.

lalinsky commented 2 years ago

Thank you for the patch, but I'll end up using my version here - https://github.com/acoustid/chromaprint/pull/120