acouvreur / sablier

Start your containers on demand, shut them down automatically when there's no activity. Docker, Docker Swarm Mode and Kubernetes compatible.
https://acouvreur.github.io/sablier/
GNU Affero General Public License v3.0
1.16k stars 43 forks source link

feat(traefik) allow websocket traffic #275

Open DrummyFloyd opened 2 months ago

DrummyFloyd commented 2 months ago

as @tomaszduda23 mentionned, i reoppend a PR to make some reviews

atm

but tested manually

with docker

i can reach ws://localhost:8080/echo container is ready , i can talk with the whoami WS even, it's not shtudown , once i stop , after session-duration hte container i stopped

edit: can i split a bit the code like

Closed: #21 #42 #152

tomaszduda23 commented 2 months ago
  • Kube => bad request (seems to be a race conditions, because runing test mannualy seems to work 302 error on first try)

This is by design you need to follow redirection. Explained in https://github.com/acouvreur/sablier/pull/241

DrummyFloyd commented 2 months ago
  • Kube => bad request (seems to be a race conditions, because runing test mannualy seems to work 302 error on first try)

This is by design you need to follow redirection. Explained in #241

will check that! thank you

EDIT: tbh , i don't fully understand what happnd , can you please have a look

DrummyFloyd commented 2 months ago
  • Kube => bad request (seems to be a race conditions, because runing test mannualy seems to work 302 error on first try)

This is by design you need to follow redirection. Explained in #241

will check that! thank you

EDIT: tbh , i don't fully understand what happnd , can you please have a look @tomaszduda23

tomaszduda23 commented 2 months ago

@acouvreur could you please enable github action on this PR. I would like to see the test results.

tomaszduda23 commented 2 months ago

It looks that you have to handle retry on client side https://github.com/trazfr/tcp-over-websocket/blob/fcb1b85e9fd0e282eee88815efeca8d729bd762b/httpClient.go#L86C14-L86C36

DrummyFloyd commented 2 months ago

It looks that you have to handle retry on client side https://github.com/trazfr/tcp-over-websocket/blob/fcb1b85e9fd0e282eee88815efeca8d729bd762b/httpClient.go#L86C14-L86C36

Will have a look a it asap

Thank you :)

tomaszduda23 commented 1 hour ago

any progress on that?