search

acowley / Frames

Data frames for tabular data.
Other
297 stars 41 forks source link

Fragment Grouping instances out and implement NFData #107

Closed cfhammill closed 6 years ago

cfhammill commented 6 years ago

Should solve #79 Also adds joins to the main Frames.hs exports

acowley commented 6 years ago

Looks good! Travis had a build error with aeson on GHC-8.0.1. Any idea as to what's going on there?

cfhammill commented 6 years ago

Hmm, not sure what's happening here, both QuickCheck and Aeson are failing to build due to the same error in template haskell.

Can't find interface-file declaration for type constructor or class Language.Haskell.TH.Lib.ExpQ
        Probable cause: bug in .hi-boot file, or inconsistent .hi file
        Use -ddump-if-trace to get an idea of which file caused the error

No idea

acowley commented 6 years ago

I got all the CI builds working yesterday. There were several issues that had accumulated. I had to disable some tests on 8.4.1 because the generated code is formatted quite differently. We'll need to look at the output on 8.4.1, visually inspect that it's what we want, and tie it into the test suite with ifdef's branching on the GHC version.

I did have to touch the joins code to accommodate a change in vinyl that re-ordered the arguments to the RSubset class. I hope there's opportunity to improve the usability of that.