search

acowley / Frames

Data frames for tabular data.
Other
297 stars 41 forks source link

fix(shell.nix): for global usage #154

Closed teto closed 3 years ago

teto commented 3 years ago

currently refers local paths which is not portable.

Also had to allow broken packages else it wouldn't enter nix-shell. I like to have haskell-language-server when going through the codebase and without these changes, I can't enter the nix-shell.

acowley commented 3 years ago

Yes, removing the local path is a good change. I’m surprised though about the allowBroken as I don’t think I have that set. What’s driving that for you?

ETA: To clarify, I do all my development with this.

teto commented 3 years ago

error: Package ‘Chart-diagrams-1.9.3’ in /nix/store/hymymnahj8czlbq3zvcjpw3nc4rb5igd-nixpkgs-chan-src/pkgs/development/haskell-modules/hackage-packages.nix:3031 is marked as broken, refusing to evaluate.

Maybe you allow broken packages already in ~/.config/nix ?

acowley commented 3 years ago

You’re completely right! Sorry I didn’t check before replying.

acowley commented 3 years ago

Thank you for doing this! I have felt a minor pang of guilt about that local path for years 😄

teto commented 3 years ago

btw why do we specify those libraries anyway ? It's nt like we can run a nix-build either. Dont you test with cabal build inside ?

acowley commented 3 years ago

Iirc, they’re almost all to remove upper bounds. That leaves us with the specific version pinned in our pinned nixpkgs.

If we let cabal find a version that works, that would require there be a published version that works or that we have cabal ignore the upper bounds, and then the precise version+revision we end up using would need a second pinning mechanism if we wanted reproducibility.