Support ffmpeg 3.x - Githubissues

acowley / ffmpeg-light

Minimal Haskell bindings to the FFmpeg library

BSD 3-Clause "New" or "Revised" License

66 stars 29 forks source link

Support ffmpeg 3.x #26

Closed TomMD closed 8 years ago

TomMD commented 8 years ago

The new 3.x version has been released with much API breakage (stated up front at release time, I haven't looked myself). Eventually, after many package systems have moved to including 3.x, we should update this package to the new API.

acowley commented 8 years ago

Thanks for opening the issue! I looked at the change log the other day and didn't see anything that would obviously break basic usage, but I haven't looked at the API yet. I hope it's not a big split for us as it would be pretty hard to maintain support for two divergent APIs.

waldheinz commented 8 years ago

The nameCompat.h stuff seems to cause breakage with FFmpeg 3. It gets erroneously included from Enums.hsc (the "fragile" old version check at the top of the file), and then it goes havoc. Simply removing the #include fixed it for me. Maybe support for such very old versions of FFmpeg can be dropped by now?

acowley commented 8 years ago

The version on master seems to work with ffmpeg-3.0 for me on OS X. Can anyone else confirm?

ETA: That it works is thanks to @waldheinz

TomMD commented 8 years ago

It builds for me and can run ./demo/Main cam properly.

waldheinz commented 8 years ago

For me it builds and runs on

Arch Linux (FFmpeg 3.0, GHC 7.10.3) and
FreeBSD (FFmpeg 2.7.2, GHC 7.10.2)

And that's all I care about. :-)