search

acowley / ffmpeg-light

Minimal Haskell bindings to the FFmpeg library
BSD 3-Clause "New" or "Revised" License
67 stars 29 forks source link

VPlay: honour the pixel aspect ratio #46

Closed gelisam closed 6 years ago

gelisam commented 6 years ago

Some video cameras produce video files with non-square pixels, so when playing on a screen with square pixels, video players need to compensate by stretching the image.

acowley commented 6 years ago

I think I may have messed you up by merging the ticks per frame PR first. Can you make sure this merges cleanly?

As usual, thank you for identifying and fixing this issue.

gelisam commented 6 years ago

I think I may have messed you up by merging the ticks per frame PR first.

Nah, the two PRs were touching the same lines and so I knew that whichever one you merged first would cause conflicts with the other one.

gelisam commented 6 years ago

Thanks for the commit bit. Would you still like me to send future improvements as PRs, or should I commit them directly?

acowley commented 6 years ago

Use your judgment. I think PRs are nice so people can ask questions and catch goofs, but moving things along is also valuable.

If it’s a new feature, I’d like to let a PR sit for a day in case anyone’s available to take a look.