search

acozzette / BUSE

A block device in user space for Linux
GNU General Public License v2.0
240 stars 47 forks source link

write_all nitpicking #36

Open divinity76 opened 3 years ago

divinity76 commented 3 years ago

1: write_all always returned a bogus 0, so it might as well return nothing, also the return value was never used for anything. 2: bytes_written should be ssize_t not int

could also mention that i'm not happy with the >0 check being just an assert but i don't address that here

acozzette commented 3 years ago

@divinity76 Thank you for the pull request but actually this project was something I did a while ago in college and am no longer working on it or maintaining it. I think if you want to use it or contribute to it you would probably be better off finding a fork that is actively maintained.

nixomose commented 3 years ago

if it's any help, I've been working on a similar project:

https://github.com/nixomose/zosbd2

I used buse originally but nbd caused me all sorts of grief so I wrote something a bit more built-to-purpose.