Pull Request for Issue92: Amptek AMDS Testing

davidChevrier commented 8 years ago

Fixed a series of memory issues in AMDS-Amptek.

A chain of ownership between AmptekSpectrumEvent, AmptekSDD123Detector, and AmptekSDD123DetectorManager led to an AMDSFlatArray being new'd and then, eventually, iteratively copied without the original being deleted. Fixed this issue by changing some members to natural pointer types and deleting after no longer needed.
Fixed two issues in AMDSFlatArray::resizeType. First was a lack of protection that caused the function to execute even when the dateType and size remained the same. Second was using resize instead of allocating new vector
Fixed an issue with QByteArray appends in the udpSocket for AmptekSDD123Server. This is like the one in AMDSClientTCPSocket
Finally, fixed a major bug that caused request types to have no valid response or acknowledge types. This meant the unbound growth of the unrequestedPackets_ in AmptekSDD123Server.

dretrex commented 8 years ago

Other that the one comment, this looks good. Time Estimate: 2 minutes

dretrex commented 8 years ago

@davidChevrier, can you do a quick double check to make sure my change is correct?

davidChevrier commented 8 years ago

Just pulled and built. Works for me.

acquaman / AcquamanDataServer