search

acquaman / AcquamanDataServer

Server architecture to provide a network and storage efficient data cache
2 stars 0 forks source link

PullRequest for Issue103: Using signal map for AMDS scaler to identify the step scan finished #130

Closed XuetaoLiu-CLS closed 8 years ago

XuetaoLiu-CLS commented 8 years ago

@davidChevrier @dretrex @iainworkman

Hi guys, pls take a look at this PR. This supposed to fix the issues. I'm running the test right now.

There are also code refactors required for this. There are some redundant codes there to be optimized. I will do that in a sub branch.

XuetaoLiu-CLS commented 8 years ago

No rush... the step scan failed...

XuetaoLiu-CLS commented 8 years ago

Scan is running now with restarting Acquaman

dretrex commented 8 years ago

Once the scans are working a bit better, post in the thread again. Then we can go over the completed code.

dretrex commented 8 years ago

Does that mean we are good for review?

XuetaoLiu-CLS commented 8 years ago

@dretrex yes, u can review now

dretrex commented 8 years ago

Just a couple comments. Time Estimate: 30 minutes

dretrex commented 8 years ago

Overall, this still looks good. Only thing now is to really make sure that we put it through its paces when we test it.

dretrex commented 8 years ago

@XuetaoLiu-CLS, those were the wrong const uses. They are const functions: bool isAcquiring() const; not const bool isAcquiring();