acquia / acquia-sdk-php

The Acquia SDK for PHP allows developers to build applications on top of Acquia services.
MIT License
25 stars 20 forks source link

Support 'discard' query param on livedev method #35

Closed weitzman closed 10 years ago

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 029474f8b64e14e156d24ef892956686f38787d3 on weitzman:livedev_discard into 7443429b4a3f22dc4cb0128042bb9219ec4b1d36 on acquia:master.

cpliakas commented 10 years ago

Great contribution! Functionality seems to work great, stylistic comments noted inline.

Tests are failing because the URL used to query the endpoint has changes, so we need to modify tests to ensure that the new URL param is picked up. Looks like there are two tests where this needs to be accounted for:

Again, thanks!

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.0%) when pulling 380e98e8d9ba0a022339fe8631fb809d9ada31a9 on weitzman:livedev_discard into 7443429b4a3f22dc4cb0128042bb9219ec4b1d36 on acquia:master.

weitzman commented 10 years ago

Think I fixed all the issues. Tests are passing. Thanks for identifying those line numbers.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling ad0d0bbec1b0c9029ae37b6361c9e7a8c3476326 on weitzman:livedev_discard into 7443429b4a3f22dc4cb0128042bb9219ec4b1d36 on acquia:master.

cpliakas commented 10 years ago

Thanks!