search

acquia / acquia-sdk-php

The Acquia SDK for PHP allows developers to build applications on top of Acquia services.
MIT License
25 stars 20 forks source link

Upgrade to Guzzle 6 #54

Open cpliakas opened 10 years ago

geerlingguy commented 9 years ago

:+1:

On install, we currently get warnings like:

Package guzzle/inflection is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/common is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/stream is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/parser is abandoned, you should avoid using it. Use guzzle/guzzle instead.
...
skwashd commented 9 years ago

Guzzle 6 is out. The AWS PHP SDK and Zendesk API libs both depend on Guzzle 6. Please consider skipping 5 and jumping straight to 6.

IlyaPokamestov commented 8 years ago

@cpliakas @Zlender do you have updates? We have some problems with this, because right now we should working with 2 different versions of guzzle in one project. And it's a little bit complex because we should handle different Exception types.

Maybe it will be better to prepare some adapters and decouple guzzle at all? It will be useful because end-user can decide which version he wants to use.

fiasco commented 7 years ago

poking this again, updating to Guzzle 6 would be very nice.

typhonius commented 7 years ago

Adding another comment to this to bump this issue as we're starting to use this library more for our deployments.

danepowell commented 7 years ago

The version of Guzzle being used here (3.x) is almost four years old. That's gotta be insecure, not to mention the fact that it produces numerous warnings whenever a project depending on this sdk is installed.

We'd love to use this in BLT, but I don't know that I'm willing to do so if it's going to produce so many bright yellow deprecation warnings, which will scare and annoy a lot of users. That's going to create a negative image for BLT and Acquia in general.

Can this be prioritized?

Edit: a quick Google reveals at least one known security issue with Guzzle 3, who knows how many more are out there: https://github.com/guzzle/guzzle3/issues/71

aaronpacheco commented 7 years ago

@Dane: This repository was maintained by people that no longer work at Acquia. It is currently unsupported.

skwashd commented 7 years ago

@aaronpacheco can the readme be upgraded to reflect this?

aaronpacheco commented 7 years ago

Done.

danepowell commented 7 years ago

Here is a new version of the SDK that uses the v2 Cloud API: https://github.com/typhonius/acquia-php-sdk-v2

I haven't tested that yet, but assuming it's functional, I'd recommend everyone deprecating this and moving to use and support acquia-php-sdk-v2.