Invalid path to credentials file on production environments

acquia / acquia-sdk-php

The Acquia SDK for PHP allows developers to build applications on top of Acquia services.

MIT License

25 stars 20 forks source link

Invalid path to credentials file on production environments #55

Closed daphneacquia closed 10 years ago

daphneacquia commented 10 years ago

Per email discussion: added dot between sitegroup and environment (instead of concatenation)

coveralls commented 10 years ago

Changes Unknown when pulling 1f79f333c925c0bc7ff2465985b7d59de3fb5cde on daphneacquia:master into \ on acquia:master**.

cpliakas commented 10 years ago

@daphneacquia Bug fix looks great, thanks for the contribution!

Looks like a test is failing after the change, so we need to modify the test at https://github.com/acquia/acquia-sdk-php/blob/master/test/Acquia/Test/Cloud/Environment/CloudEnvironmentTest.php#L136 to reflect the fixed filepath.

coveralls commented 10 years ago

Changes Unknown when pulling cc564e2963b134cbd91096f0e65caa55b33e012f on daphneacquia:master into \ on acquia:master**.

cpliakas commented 10 years ago

Hi @daphneacquia.

Are you still working on this issue, or has it been deprecated by pull request at #56 that was merged? If this is still in progress, let me know and I can provide some guidance on the next steps.

Thanks! Chris

daphneacquia commented 10 years ago

Deprecated by pull request: thanks for checking!

cpliakas commented 10 years ago

Thanks for reporting back, closing as a dup.