WIP: Upgrade to Guzzle 5

acquia / acquia-sdk-php

The Acquia SDK for PHP allows developers to build applications on top of Acquia services.

MIT License

25 stars 20 forks source link

WIP: Upgrade to Guzzle 5 #69

Open webbj74 opened 9 years ago

webbj74 commented 9 years ago

This is a work in progress, mostly concentrated on CloudApiClient. I've tested a handful of the CloudApiClient "read-only" API methods against a live site and those are all behaving as expected. I have not tested any task-initiating API methods. I've tried to keep things as backward compatible as possible.

To do:

[ ] test task-initiating CloudApiClient methods
[ ] need to update Acquia\Network\AcquiaNetworkClient
[ ] need to update Acquia\Search\AcquiaSearchClient
[ ] phpunit tests need to be rewritten for Guzzle 5
[ ] sub-project composer.jsons needs to updated

cpliakas commented 9 years ago

@webbj74 You may just be my favorite person in the world today. Thanks for taking a first pass at this, excellent work.

webbj74 commented 9 years ago

In testing I discovered that the CloudApiClient methods addSshKey, addSvnUser, addDatabase, moveDomain, and downloadDatabaseBackup are broken in commit bfb6830. I'll have an update to these soon.

I also discovered that deleteDatabase sets a parameter default which is no longer valid (per CL-7612). The parameter is still allowed, but throws a HTTP 400 unless ?backup=0

Also installDistroByName uses an install type ('distro_name') which was removed a while ago (CL-6842)