search

acquia / acquia-sdk-php

The Acquia SDK for PHP allows developers to build applications on top of Acquia services.
MIT License
25 stars 20 forks source link

acquia-search-governor-php cannot read stored auth data #79

Open magtak opened 5 years ago

magtak commented 5 years ago

I know the code doesn't seem to make a lot of sense, and I cannot figure out what the bug is, but with PHP 7.1 (after the Mojave update) this very simple function

public function getClient($group, $name)
    {
        return isset($this[$group][$name]) ? $this[$group][$name] : null;
    }

... will return null even though the ArrayObject $this should have populated properties in it's storage. If you access those properties (e.g. with a print_r, or var_dump, or even assign them to a variable) before the isset is called, it all just works as expected.

bhusalm-acq commented 3 years ago

@magtak what's blocking this from getting it merged? All the ops are having to do manual steps do get governor working now. It would be great for governor.phar users if this PR can be merged and get the issue fixed