acquia / blt-simplesamlphp

Acquia BLT plugin for integration with SimpleSAMLPhp
GNU General Public License v2.0
1 stars 7 forks source link

vendor/acquia/blt/settings/simplesamlphp.settings.php Gone #5

Open danshumaker opened 3 years ago

danshumaker commented 3 years ago

Hi, In an older (BLT 11 I believe) setup, we had a vendor/acquia/blt/settings/simplesamlphp.settings.php file in the blt directory which was then loaded by BLT's config loading code here:

// Default global settings.
$blt_settings_files = [
  'cache',
  'config',
  'logging',
  'filesystem',
  'simplesamlphp',     <-------------------------------------------
  'misc',
  'drush-request-trace',
];
foreach ($blt_settings_files as $blt_settings_file) {
  $settings_files[] = __DIR__ . "/$blt_settings_file.settings.php";
}

foreach ($settings_files as $settings_file) {
  if (file_exists($settings_file)) {
    // phpcs:ignore
    require $settings_file;
  }
}

In this newer version 12 version of BLT (using the blt-simplsamlphp plugin) I see that the blt.settings.php file loader still expects the simplesamlphp file to be there but it is missing from the blt repo.

I'm trying to debug why my simplesaml config is not loading.

I'm sort of assuming that the creation of this blt-simplesamlphp plugin takes care of loading the simplesamlphp/config/acquia_config.php and simplesamlphp/config/config.php files INSTEAD of the old blt.settings.ph method. Is that correct?

Has the blt code just not been updated yet? Or should I take an older copy of the simplesamlphp.settings.php file and put it into my current Drupal9.1.2 acquia code base? I'm assuming if the blt repo is not updated then this line should go away eventually: https://github.com/acquia/blt/blob/bf8ab98f12a67127f6c2261ca91bcd9d4d75ae87/settings/blt.settings.php#L118

Thank you!

danshumaker commented 3 years ago

For now I'm going to tack the sourcing of the file into the loader via the other "global" loading code:

Hopefully this will work. 2021-02-08_14-57-21