acquia / blt

Acquia's toolset for automating Drupal 8 and 9 development, testing, and deployment.
https://docs.acquia.com/blt/
GNU General Public License v2.0
442 stars 394 forks source link

BLT-5201: Errors after upgrading to 13.7 #4653

Open jedgar1mx opened 1 year ago

jedgar1mx commented 1 year ago

Describe the bug I'm trying to upgrade blt to the latest version. I'm still stuck with 13.5.1 due to the changes in drupal-environment-detector. I'm using acquia/blt-travis to run tests on travis-ci. After switching to the master branch, travis-ci seems to work correctly with the latest blt. However, I now get issues with acquia-pipelines.

Expected behavior Test should run successfully on both travis-ci and acquia-pipelines with latest BLT version.

Detailed error output `[info] Drush bootstrap phase: bootstrapDrupalConfiguration()

TypeError: Acquia\BltTravis\Blt\Plugin\EnvironmentDetector\TravisDetector::getCiSettingsFile(): Return value must be of type string, none returned in Acquia\BltTravis\Blt\Plugin\EnvironmentDetector\TravisDetector::getCiSettingsFile() (line 16 of /mnt/tmp/local.prod/source/vendor/acquia/blt-travis/src/Blt/Plugin/EnvironmentDetector/TravisDetector.php).

[warning] Drush command terminated abnormally.

[Acquia\Blt\Robo\Tasks\DrushTask] Exit code 1 Time 0.19s

[error] Failed to install Drupal! For troubleshooting guidance and support, see https://docs.acquia.com/blt/support/ `

mikemadison13 commented 1 year ago

what version of the blt-travis plugin do you have? theoretically https://github.com/acquia/blt-travis/pull/5/files fixed this issue but maybe I missed something?

jedgar1mx commented 1 year ago

I'm using master https://github.com/acquia/blt-travis/commit/00bf8d705b12bc9e931a90395f61617c792c9ad8

I tried 1.0.3 but it would error out as soon as I tried to update locally.

Thanks @mikemadison13